Head/Senior Maintainer/Coder application for YoYoBatty

YoYoBatty
Head Coder
Posts: 30
Joined: June 1st, 2018, 6:31 am

Head/Senior Maintainer/Coder application for YoYoBatty

Post by YoYoBatty » December 19th, 2018, 6:34 pm

Name(s) (ckey, discord name, ingame name too if you staticname): I don't static name
Country: Canada
Timezone: EST
Age: 22
Merged PRs made by you on the Hippie Station codebase (links): Made PRs https://github.com/pulls?q=is%3Apr+auth ... s%3Aclosed https://github.com/yoyobatty
>1,108 contributions in the last year
How experienced are you with DM, in your opinion, from 1 to 10?: Probably 8 or 9
Additional known programming languages: ones and zeroes lol
Any other additional information:

Please gimme.
freshonionvendor
Posts: 184
Joined: May 8th, 2018, 12:13 pm

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by freshonionvendor » December 19th, 2018, 6:37 pm

great boi +1
User avatar
Carbonhell
Game Master
Posts: 274
Joined: May 7th, 2018, 9:50 pm

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by Carbonhell » December 20th, 2018, 12:24 pm

A head coder should focus on not letting any kind of broken code in, and should make all maintainers (therefore himself too) follow all the guidelines and policies of the code base. You already proved you sometimes let PR slip in without doing a complete code-check, causing serious problems (See: missing right leg, you can say it was the mirror bot's fault, but it is a bot and it's the maintainers' job to actually check if the mirror is good enough, and the error was very obvious albeit concealed by the huge amount of changes).
Casually checking your PRs, I also see some issues. Examples:
https://github.com/HippieStation/Hippie ... /pull/9991 There's an actual framework to handle our preferences without touching /tg/ defines. I don't think this PR works as you expected.
It also took you three PRs to fix mentor say, which points at the fact you may be not testing your PRs well:
https://github.com/HippieStation/Hippie ... /pull/9937
https://github.com/HippieStation/Hippie ... /pull/9938
https://github.com/HippieStation/Hippie ... /pull/9949

With this, I'm in no way criticizing you or your work as a maintainer, you're clearly one of the main reason hippie is still alive code-wise, your amount of contributions is huge, counting the mirrors you check as well and your PRs. But I think a head coder should be held at way higher standards, and currently the only one i believe he could be fit is karma, skill wise, although he's kinda new so i'm still worried in general since I don't exactly know how much he's skilled with DM in specific. I hope you're not gonna take this personally, I'm just worried about the level of power and responsibilities this role will give.
YoYoBatty
Head Coder
Posts: 30
Joined: June 1st, 2018, 6:31 am

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by YoYoBatty » December 20th, 2018, 7:00 pm

My biggest issue is web edits. Starting tomorrow I will actually be at my main PC from now on so I can test my hotfixes. I think my track record is reasonably clean considering these are only a handful of mentions out of 1108+ contributions. If I were to be in a senior/head maintainer position then I would do my absolute best to reflect integrity in my work by not being a lazy web editing cunt I've been in the past few months.
User avatar
QuarianCommando
Game Admin
Posts: 115
Joined: May 27th, 2018, 8:42 pm

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by QuarianCommando » December 20th, 2018, 7:01 pm

-1 for pinging admins to self advertise.
YoYoBatty
Head Coder
Posts: 30
Joined: June 1st, 2018, 6:31 am

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by YoYoBatty » December 20th, 2018, 7:02 pm

How dare I ask for input in the discord.
User avatar
Xenon
Game Master
Posts: 679
Joined: May 7th, 2018, 10:02 pm

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by Xenon » December 20th, 2018, 7:18 pm

I don't think you can apply to be head maintainer.
VI SITTER HÄR I VENTEN OCH SPELAR LITE DOTA
User avatar
karma
Maintainer
Posts: 45
Joined: November 6th, 2018, 11:32 pm

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by karma » December 20th, 2018, 7:26 pm

+1 only active maintainer aside me
YoYoBatty
Head Coder
Posts: 30
Joined: June 1st, 2018, 6:31 am

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by YoYoBatty » December 21st, 2018, 2:20 pm

Yeah, all roles need to be applied to, Carbon said this is a valid app *shrug*
User avatar
Carbonhell
Game Master
Posts: 274
Joined: May 7th, 2018, 9:50 pm

Re: Head/Senior Maintainer/Coder application for YoYoBatty

Post by Carbonhell » December 22nd, 2018, 9:01 am

YoYoBatty wrote:
December 20th, 2018, 7:00 pm
My biggest issue is web edits. Starting tomorrow I will actually be at my main PC from now on so I can test my hotfixes. I think my track record is reasonably clean considering these are only a handful of mentions out of 1108+ contributions. If I were to be in a senior/head maintainer position then I would do my absolute best to reflect integrity in my work by not being a lazy web editing cunt I've been in the past few months.
No they are not the only issues,i just picked the most recent ones. That said, you did fuck up a lot during your time here, so be sure to be more careful.
Locked